Graceful handling of network errors #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
force-pushed
the
graceful-handling-of-network-errors
branch
from
bd2e556
to
e7e68ad
Compare
acdha
force-pushed
the
graceful-handling-of-network-errors
branch
from
e7e68ad
to
b9f2bc4
Compare
This avoids log messages showing undefined before the data has been demand-loaded, such as from the reservation updates.
acdha
force-pushed
the
graceful-handling-of-network-errors
branch
from
b34efaa
to
d7e8f0c
Compare
|
@rstorey I'm a little iffy about this because it appears to mostly affect Chrome on Chrome OS or smarthphones and I haven't been able to find a way to reproduce it. This commit changes the code to at least handle that situation more gracefully than it does now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a fix for https://errorlogging.loc.gov/share/issue/3569473f7b46460f91ccbaaa428fedfb/ which seems to only affect users of Chrome smartphones. I have not yet been able to reproduce it in a standard Chrome build.