Jenkins cloudformation #1098
Merged
Jenkins cloudformation #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Aug 14, 2019
| @@ -16,7 +16,7 @@ RUN apt-get update -qy && apt-get dist-upgrade -qy && apt-get install -o Dpkg::O | |||
| libtiff-dev libjpeg-dev libopenjp2-7-dev libwebp-dev zlib1g-dev \ | |||
| graphviz \ | |||
| locales \ | |||
| nodejs && apt-get -qy -t stretch-backports install npm && apt-get -qy autoremove && apt-get -qy autoclean | |||
| nodejs node-gyp && apt-get -qy -t stretch-backports install npm && apt-get -qy autoremove && apt-get -qy autoclean | |||
There was a problem hiding this comment.
The node-gyp package might not be installable from NPM just due to upstream breakage, which is common enough that I remember it by name. Installing it from APT should be a big stability improvement.
acdha
reviewed
Aug 14, 2019
| usermod -aG docker jenkins | ||
| snap install postgresql96 | ||
| pip3 install awscli --upgrade |
There was a problem hiding this comment.
This is an interesting judgement call: awscli releases frequently enough that I tend to pip install it to get access to new features but if we're not using it having that be cached should be more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to provision a new Jenkins server and took the opportunity to check in more of the configuration in case it needs to happen again.