Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: reduce the fields included in user exports #648

Merged
merged 2 commits into from Nov 20, 2018

Conversation

acdha
Copy link
Member

@acdha acdha commented Nov 19, 2018

See #624

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 71.722% when pulling 561add7 on update-admin-user-export-columns into 9c2aeb7 on master.

Copy link
Member

@rstorey rstorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these changes, but I'd like @elainekamlley to confirm the fields they want - did they want to remove some of the extraneous fields, or only include the username and email address?

Copy link
Collaborator

@elainekamlley elainekamlley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. The only concern I had is that the export included password hashes.

@rstorey rstorey merged commit 0996c59 into master Nov 20, 2018
@rstorey rstorey deleted the update-admin-user-export-columns branch December 11, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants