Replace code copied from django-passwords #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complexity validator was copied from @dstufft’s django-passwords project in violation of the license: https://github.com/dstufft/django-passwords/blob/master/LICENSE Based on 56f08d2 this might have been an attempt to make it compatible with the official Django password validation API added in Django 1.9. This commit changes that to use django-passwords directly and just wraps the interface slightly.
rstorey
approved these changes
Dec 6, 2018
Sprint 15 Nov. 26th - Dec. 7th
automation
moved this from Review
to Done - ready for testing
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity validator was copied from @dstufft’s django-passwords project in violation of the license:
https://github.com/dstufft/django-passwords/blob/master/LICENSE
Based on 56f08d2 this might have been an attempt to make it compatible with the official Django password validation API added in Django 1.9, which is slightly different from the form validation API. This commit changes that to use django-passwords directly and just wraps the interface rather than duplicating the actual code.