Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cfn-lint errors #747

Merged
merged 1 commit into from Jan 4, 2019
Merged

Fix cfn-lint errors #747

merged 1 commit into from Jan 4, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Jan 4, 2019

Quotation marks - mostly removing, at least one case of adding

@rstorey rstorey requested a review from acdha January 4, 2019 20:34
@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited

Coverage Status

Coverage increased (+0.08%) to 70.162% when pulling 63f16e6 on fix-cfn-lint-errors into 43b5834 on master.

acdha
acdha approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I love the consistency of AWS where numbers and booleans should not be quoted except for the places where they should…

@rstorey rstorey merged commit 37592f7 into master Jan 4, 2019
@acdha acdha deleted the fix-cfn-lint-errors branch January 4, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdha acdha acdha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rstorey @coveralls @acdha