Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export transcription files for blank transcriptions #748

Merged
merged 1 commit into from Jan 8, 2019
Merged

Don't export transcription files for blank transcriptions #748

merged 1 commit into from Jan 8, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Jan 8, 2019

No description provided.

@rstorey rstorey requested a review from acdha January 8, 2019 18:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 70.044% when pulling 3ccc649 on no-empty-transcriptions into 37592f7 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 70.044% when pulling 3ccc649 on no-empty-transcriptions into 37592f7 on master.

acdha
acdha approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this change but it seems like it creates a communications challenge for the recipients being able to distinguish between pages which have not been transcribed yet and those which have and are simply empty.

@rstorey rstorey merged commit 7888959 into master Jan 8, 2019
@rstorey rstorey deleted the no-empty-transcriptions branch January 9, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdha acdha acdha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rstorey @coveralls @acdha