New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue reviewing after accept #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirect_to_next_reviewable_asset
and redirect_to_next_transcribable_asset
are very similar. It seems like we could have those functions be almost entirely reusable except for the initial asset queryset filter.
concordia/views.py
Outdated
) | ||
potential_assets = potential_assets.filter( | ||
transcription_status=TranscriptionStatus.SUBMITTED, | ||
assettranscriptionreservation=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assettranscriptionreservation
shouldn't be relevant for review since that's only used when editing.
concordia/views.py
Outdated
@@ -1164,7 +1241,7 @@ def redirect_to_next_transcribable_asset(request, *, campaign_slug): | |||
next_asset=Case( | |||
When(pk__gt=asset_id, then=1), default=0, output_field=IntegerField() | |||
), | |||
).order_by("-next_asset", "-unstarted", "-same_project", "-same_item", "sequence") | |||
).order_by("-next_asset", "-unstarted", "-same_item", "-same_project", "sequence") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing the test to fail because it no longer prioritizes staying in the same project ahead of staying in the same campaign.
…language in accept modal dialog
…() from within the main view method
My effort to de-dupe the code was fruitless. It caused the never_cache decorator to fail for a reason that I'm not quite sure of. In any case, although the two methods are very similar, they aren't exactly the same and there seems to be some kind of reason why never_cache wants the redirect call to be in the main view method. It was worth a try. |
|
But the returned |
Refs #749