Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display unique tag values #807

Merged
merged 4 commits into from Feb 11, 2019
Merged

Display unique tag values #807

merged 4 commits into from Feb 11, 2019

Conversation

acdha
Copy link
Member

@acdha acdha commented Feb 8, 2019

This addresses part of #806 by only display the unique tag values even if multiple people have saved the same tag value. We probably also want to have some logic about only saving tags for the current user which they added but that might want to be part of the larger discussion about what this feature is intended to do since it's reasonable to think people might want to “vote” on tags being appropriate by seconding them.

@coveralls
Copy link

coveralls commented Feb 8, 2019

Coverage Status

Coverage increased (+0.09%) to 69.676% when pulling 2ea8d19 on display-unique-tag-values into 4411960 on master.

@acdha acdha changed the base branch from master to cantaloupe February 8, 2019 20:00
@acdha acdha changed the base branch from cantaloupe to master February 8, 2019 20:00
@rstorey rstorey merged commit 775d6b4 into master Feb 11, 2019
@rstorey rstorey deleted the display-unique-tag-values branch February 11, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants