Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB scripts: Add region to aws command, use python instead of python3 #828

Merged
merged 3 commits into from Mar 11, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Feb 26, 2019

Still need to make a couple more changes before this is ready:

  • make ENV_NAME come from outside so it's set by the CloudFormation template rather than at the top of the script
  • add region to the restore script

@rstorey rstorey self-assigned this Feb 26, 2019
@coveralls
Copy link

coveralls commented Feb 26, 2019

Coverage Status

Coverage increased (+0.03%) to 69.67% when pulling e5b2f9a on update-db-scripts into 5229350 on master.

acdha
acdha previously approved these changes Mar 11, 2019
Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this. If we wanted to be pedantically proper about this we could scrape the region into AWS_DEFAULT_REGION from the EC2/ECS instance metadata but I think we can way until it's deployed in n > 1 regions before caring about that.

@rstorey rstorey changed the title WIP: DB scripts: Add region to aws command, use python instead of python3 DB scripts: Add region to aws command, use python instead of python3 Mar 11, 2019
@rstorey rstorey merged commit 64e3f54 into master Mar 11, 2019
@rstorey rstorey deleted the update-db-scripts branch March 11, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants