Load FontAwesome from CDNJS #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This consolidates all of our usage on a single service which also uses the CloudFlare infrastructure and upgrades from 5.7.1 to 5.7.2, which finally completes #465.
klee72
previously approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Just checked random pages and it's working great. However I noticed that we're using both 'fa' and 'fas' classes. Although 'fa' is still allowed in version 5, we'll probably want to just use 'fas' and 'fab' for future proofing, probably should be addressed in another ticket.
|
Agreed — I was also wondering whether we should be migrating to only loading the symbols we use or only loading SVG but that's more of a longer-term discussion about our front-end tools than something I want to tackle now. |
This is the SHA-256 value from https://pypi.org/project/isort/#files for the wheel package (the other value is the .tar.gz file) for the update included in d7474f3
rstorey
approved these changes
Feb 28, 2019
|
Merging so I can get the isort fix into master |
|
Thanks - I was going to cherry-pick it but both changes are small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that cdnjs/cdnjs#12307 is done we can finally complete #465 by consolidating all of our usage on a single service which uses the same CDN as the main site and also upgrades from 5.7.1 to 5.7.2.