Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: workaround for XML reporting bug #857

Merged
merged 3 commits into from Mar 20, 2019
Merged

Conversation

acdha
Copy link
Member

@acdha acdha commented Mar 20, 2019

There’s a bug in coverage.py when using the source specifier which causes the XML reports to omit the first element of the directory name, breaking some tools (this does not affect the HTML or text format reports).

Using include instead avoids this problem until the upstream bug is resolved: nedbat/coveragepy#578

Before merging, we should see a big jump up in the coverage numbers on https://sonarcloud.io/dashboard?id=LibraryOfCongress_concordia because the values in the coverage.xml file will have the full file paths it's looking for.

There’s a bug in coverage.py when using the source
specifier which causes the XML reports to omit the
first element of the directory name, breaking some
tools (this does not affect the HTML or text 
format reports).

Using include instead avoids this problem until
the upstream bug is resolved:

nedbat/coveragepy#578
@acdha acdha added bug Something isn't working infrastructure labels Mar 20, 2019
@acdha acdha self-assigned this Mar 20, 2019
@acdha acdha requested a review from rstorey March 20, 2019 14:19
@acdha acdha marked this pull request as ready for review March 20, 2019 14:41
This allows builds to start faster but still has the full
history available for code analysis
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.833% when pulling 6a5947b on fix-coverage-xml-reports into f24f8ba on master.

@coveralls
Copy link

coveralls commented Mar 20, 2019

Coverage Status

Coverage increased (+0.1%) to 69.833% when pulling 6a5947b on fix-coverage-xml-reports into f24f8ba on master.

@acdha acdha merged commit 9e20cb1 into master Mar 20, 2019
@acdha acdha deleted the fix-coverage-xml-reports branch March 20, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete file path in XML report
2 participants