Set conn_max_age to nonzero if env var is present in ECS environment #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Mar 27, 2019
acdha
reviewed
Mar 27, 2019
concordia/settings_ecs.py
Outdated
| @@ -87,3 +87,6 @@ | |||
| "Transcribed and reviewed by volunteers participating in the " | |||
| "By The People project at crowd.loc.gov." | |||
| ) | |||
|
|
|||
| if os.getenv("CONN_MAX_AGE_NONZERO"): | |||
There was a problem hiding this comment.
Since we're not setting this to the actual value, what do you think about renaming this to something like USE_PERSISTENT_DATABASE_CONNECTIONS?
acdha
approved these changes
Mar 27, 2019
| @@ -87,3 +87,6 @@ | |||
| "Transcribed and reviewed by volunteers participating in the " | |||
| "By The People project at crowd.loc.gov." | |||
| ) | |||
|
|
|||
| if os.getenv("USE_PERSISTENT_DATABASE_CONNECTIONS"): | |||
There was a problem hiding this comment.
I'm not sure we want to explicitly test here since we don't otherwise define this value but it might be a good future-proofing move:
Suggested change
| if os.getenv("USE_PERSISTENT_DATABASE_CONNECTIONS"): | |
| if os.getenv("USE_PERSISTENT_DATABASE_CONNECTIONS") == "1": |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.