Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to set the path for new simple pages #875

Merged
merged 1 commit into from Mar 29, 2019

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Mar 29, 2019

This bug fix will allow you to be able to set the path for the new resources page.

@rstorey rstorey self-assigned this Mar 29, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 69.55% when pulling 2e6e6cb on enable-new-simplepages into dd8ccaf on master.

@coveralls
Copy link

coveralls commented Mar 29, 2019

Coverage Status

Coverage remained the same at 69.516% when pulling 2e6e6cb on enable-new-simplepages into dd8ccaf on master.

@rstorey rstorey merged commit 3ed81fa into master Mar 29, 2019
@rstorey rstorey deleted the enable-new-simplepages branch March 29, 2019 19:43
@acdha
Copy link
Member

acdha commented Apr 1, 2019

Since we're reversing part of the decision about the simple pages’ design, do we want to go further by adding validation for the path values (either to prevent conflicts or to ensure that the route exists first), or to add this as a 404 handler so new paths can be added any time they don't conflict?

@rstorey
Copy link
Member Author

rstorey commented Apr 2, 2019

I'm not clear on what's being reversed here. How are admins supposed to create new simple pages with the path set to read only?

@acdha
Copy link
Member

acdha commented Apr 2, 2019

When we added the simple page feature, I had asked about the ability to add new pages and it was agreed that this would not be allowed — only the existing static pages would be available. Since we're changing that decision we probably also want to update the UI around the paths to avoid confusion.

@rstorey
Copy link
Member Author

rstorey commented Apr 2, 2019

Ahhhhh. Yup, changing that decision. I will ticket this for a future sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants