Use P1 thumbnail image for social share on asset page #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
approved these changes
Apr 23, 2019
| thumbnail_url = asset.download_url.replace( | ||
| "http://tile.loc.gov", "https://tile.loc.gov" | ||
| ) | ||
| thumbnail_url = thumbnail_url.replace("/pct:100/", "/!512,512/") |
There was a problem hiding this comment.
I'm wondering whether we should use https://github.com/Princeton-CDH/piffle for this — it's more processing to parse the URLs but would give us a higher degree of confidence that it won't break unexpectedly and would be more future-proof for other outside sources.
There was a problem hiding this comment.
I ticketed that here: #910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #892