Take out newline in entrypoint test sentry config command #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Apr 24, 2019
| @@ -16,7 +16,7 @@ echo "Ensuring our base configuration is present in the database" | |||
|
|
|||
| if [ -v SENTRY_BACKEND_DSN ]; then | |||
| echo "Testing Sentry configuration" | |||
| echo "from sentry_sdk import capture_message;capture_message('This is a test event')\n" | ./manage.py shell | |||
There was a problem hiding this comment.
This seems like it might be approaching an argument for turning this into a management command which can be linted and tested more easily
There was a problem hiding this comment.
I was kind of hoping that feature would make its way into the new sentry SDK eventually.
There was a problem hiding this comment.
I ticketed that for future work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more bugfix for the entrypoint script.