Remove display of the actual difficulty score #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual values are still used for sorting but now the numeric score will no longer be visible. See #930
rstorey
reviewed
May 13, 2019
| @@ -265,7 +260,6 @@ class AssetListItem { | |||
| this.el.classList.add('asset', 'border'); | |||
| this.el.dataset.image = thumbnailUrl; | |||
| this.el.dataset.id = assetData.id; | |||
| this.el.dataset.difficulty = assetData.difficulty; | |||
There was a problem hiding this comment.
Do we need this to maintain sorting functionality?
There was a problem hiding this comment.
We used to but 1626184 removed that dependency because we're now using the re:dom keyed-list model which always receives our asset record instead of the DOM element. I removed it on the theory that it was work we weren't currently benefiting from.
rstorey
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual values are still used for sorting but now the numeric score will no longer be visible.
See #930