Retain the full list of every asset which has been interacted with #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the earlier logic we had for including assets immediately after changing them to retain a list of every asset which has been the target of some sort of action (even if that wasn’t successful) so they don’t disappear until you close the page. This doesn’t implement a full history — which is likely to want improvement since there isn’t a command to, say, take you back through the history of pages you’ve been looking at — but it does ensure that you can do things like Review -> Edit -> Transcribe and never have the asset be _gone_.
rstorey
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the earlier logic we had for including assets immediately after changing them to retain a list of every asset which has been the target of some sort of action (even if that wasn’t successful) so they don’t disappear until you close the page. This doesn’t implement a full history — which is likely to want improvement since there isn’t a command to, say, take you back through the history of pages you’ve been looking at — but it does ensure that you can do things like Review -> Edit -> Transcribe and never have the asset be gone.
We might want to consider something like filtering out the assets which aren't appropriate for the current mode unless you just changed that asset but the logic for that made me want to consider how confusing the user experience would be before doing anything.