Add Controller Input #110
Merged
Add Controller Input #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! |
HaSa1002
commented
Aug 28, 2021
Comment on lines
-405
to
+414
| if Input.is_action_pressed("ui_up"): | ||
| if Input.is_action_pressed("acc+"): | ||
| soll_command += 0.7 * delta | ||
| if Input.is_action_pressed("ui_down"): | ||
| if Input.is_action_pressed("acc-"): | ||
| soll_command -= 0.7 * delta | ||
| if soll_command >= 1: | ||
| soll_command = 1 | ||
| if soll_command <= -1: | ||
| soll_command = -1 | ||
| if Input.is_action_pressed("ui_left"): | ||
| if Input.is_action_pressed("brake-"): | ||
| soll_command = 0 | ||
| if Input.is_action_pressed("ui_right"): | ||
| if Input.is_action_pressed("brake+"): |
There was a problem hiding this comment.
Do you mean that one?
The behaviour is the same
|
Just drive the tutorial track on this branch with Easy Mode and arrow keys... WASD Steering is also different to the version of master branch... |
|
I fixed the arrow key steering. Maybe I am blind, but how is WASD steering different? Are the acceleration or break axis inversed? |
Co-Authored-By: Jean28518 <jf_v@gmx.de>
HaSa1002
force-pushed
the
controller-input-2
branch
from
5735c24
to
c01ffa4
Compare
|
Your last commit removed WASD controls completly. Was that planned? |
|
Yes, that was planned :) |
nalquas
added
ux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also did some refactoring. For example, you can shorten
TranslationServer.translate()totr(), use_unhandled_input_eventinstead of_processto process input actions, and use GDScript format strings, to build strings.THe change itself:
I added bindings for controllers (the easy part) and a new class called InputLabel that changes the input based on the device and supplied action. In order to insert any control into the translations they need to use format strings as well. Luckily
%sconverts anything that can be casted to a string (which is everything).The detection of the used controller is incomplete, so everytime somebody reports a new GUID, it has to be added or we go and grab a SDL controller DB dumb an integrate that or we add a Godot Method with the most common gamepad types.
Lastly we should implement input settings. It should be relativly easy now, but I wanted to finish this PR to get into bed and back to my primary work. Please review carefully, as I had to a rebase way to late in the night.
Fixes #105