About page #128

bodamat · 2021-09-04T21:27:54Z

Create about page #124
To add new people just update AboutPeople.csv

bodamat · 2021-09-04T21:28:38Z

I forgot add button for mobile :)

bodamat · 2021-09-04T21:34:54Z

Now all done :)

HaSa1002 · 2021-09-05T12:18:45Z

I don't think a CSV table is the best suited data format for saving contributers.
I would list contributers in a markdown or text file. Also please use the names listed on the GitHub profile/used in commits as contributer name.

src/Translations/MainMenu.csv

HaSa1002

Looks good, just left a few ideas to improve the code

HaSa1002 · 2021-09-05T12:46:48Z

src/addons/Libre_Train_Sim_Editor/Data/Modules/MainMenu.tscn

+[node name="Fam1" type="Label" parent="About/ColorRect/Control/ScrollContainer/VBoxAbout/BigThankYou/VBoxContainer"]
+margin_right = 1138.0
+margin_bottom = 45.0
+custom_fonts/font = ExtResource( 5 )
+text = "Mother"
+align = 1
+valign = 1
+__meta__ = {
+"_edit_use_anchors_": false
+}
+
+[node name="Fam2" type="Label" parent="About/ColorRect/Control/ScrollContainer/VBoxAbout/BigThankYou/VBoxContainer"]
+margin_top = 49.0
+margin_right = 1138.0
+margin_bottom = 94.0
+custom_fonts/font = ExtResource( 5 )
+text = "Father"
+align = 1
+valign = 1
+__meta__ = {
+"_edit_use_anchors_": false
+}
+
+[node name="Fam3" type="Label" parent="About/ColorRect/Control/ScrollContainer/VBoxAbout/BigThankYou/VBoxContainer"]
+margin_top = 98.0
+margin_right = 1138.0
+margin_bottom = 143.0
+custom_fonts/font = ExtResource( 5 )
+text = "Other members in my family"
+align = 1
+valign = 1
+__meta__ = {
+"_edit_use_anchors_": false
+}


I don't think this is necessary

Yes, this is not necessary, but give more kind to the project :)

idk. I wouldn't do it

in some project, I saw this, but of course not in commercial projects :)

src/addons/Libre_Train_Sim_Editor/Data/Modules/MenuAbout.gd

src/project.godot

bodamat · 2021-09-05T17:01:52Z

I don't think a CSV table is the best suited data format for saving contributers.
I would list contributers in a markdown or text file. Also please use the names listed on the GitHub profile/used in commits as contributer name.

I also think about this, but easily and fast parse in Godot I use csv

bodamat · 2021-09-05T17:16:59Z

Thanks @HaSa1002 for reviewing my code

HaSa1002 · 2021-09-05T17:29:28Z

Thinking more about the format question, what about using a Resource? We can edit them in Engine and we don't need to parse them. Just create one like this:

class_name Authors
extends Resource

export(Array, String) authors := []
export(Array, Array, String) translators := [] # structure will be [[Name, Language]]

then just create the resource in the file system and assign it in your about script using

export var authors: Authors

bodamat · 2021-09-05T17:31:18Z

I forgot about this idea, thanks. It should be much better. Do we need separate main developers and contributors?

bodamat · 2021-09-05T17:46:56Z

Good idea, but this method also has disadvantages. This is so hard to update now, maybe in Godot 4.0, it changes. Can't change order position in Array and can't redo operation

HaSa1002 · 2021-09-05T19:02:12Z

But the order doesn't matter?
Keep in mind, you can just edit the tres file by hand in a text editor

bodamat · 2021-09-05T19:03:29Z

for language matter, but the only first index of array :) Dictionary is not enough to make also usable

src/about_authors.gd

HaSa1002 · 2021-09-05T19:10:34Z

and please rename about_authors.gd to authors.gd

HaSa1002 · 2021-09-05T19:16:46Z

Do you want to group authors by their language?

bodamat · 2021-09-05T19:19:26Z

yes, I want to group it. You can see this now in the last commit

HaSa1002 · 2021-09-05T19:21:08Z

Okay then just do

bodamat · 2021-09-05T19:24:02Z

Where do you get ideas? :)

HaSa1002

You could iterate like this

HaSa1002 · 2021-09-05T19:13:22Z

src/addons/Libre_Train_Sim_Editor/Data/Modules/MenuAbout.gd

+export(NodePath) var developers_vbox
+export(NodePath) var contributors_vbox
+export(NodePath) var translators_vbox
+export(Resource) var authours = authours as Authors


Suggested change

export(Resource) var authours = authours as Authors

export(Resource) var authors

I can't do this, because I miss a hint from the editor about what Resource I want to use. I know it will fix in Godot 4.0

yeah but just fix the name (authors may work for hours, but the words are unrelated) and remove the assign. It is not needed. You could do

Suggested change

export(Resource) var authours = authours as Authors

export(Resource) var authors = null

and do assert(authors != null) in _ready

but I will don't have autocomplete. Problem not about is null or not

But using the approach you used, you don't have autocompletion as well

in code, I have, but not in the editor in inspector

src/addons/Libre_Train_Sim_Editor/Data/Modules/MenuAbout.gd

bodamat · 2021-09-05T21:05:51Z

How to use Resources created from class Author:

For Developers and Contributors just add a new item and add text. The first is a name and the second is GitHub name after -. If you don't know the real name just add a GitHub account.
For Translators add a new item what is Array. The first item in this Array is the language name and the other is people who help with translations. If you don't know the real name just add a GitHub account instead of the real name.

HaSa1002 · 2021-09-05T23:57:56Z

Can you please squash all the commits into one?
You can either rebase or do a soft reset and create a new commit.

Rebase

git rebase HEAD~12 -i, then change the eleven last picks to for fixup.
git push -f, once done

Soft reset

git reset --soft HEAD~12
git commit -m "Add about page"
git push -f

bodamat · 2021-09-07T00:24:59Z

I merged commits. It was pretty hard

HaSa1002

I did a quick test and it works fine. Just one thing left to ensure it works on all screens

src/addons/Libre_Train_Sim_Editor/Data/Modules/MainMenu.tscn

src/addons/Libre_Train_Sim_Editor/Data/Modules/MenuAbout.gd

HaSa1002

Nice work

Jean28518 · 2021-09-14T09:41:02Z

Very nice work!

Thank you!

HaSa1002 reviewed Sep 5, 2021

View reviewed changes

src/Translations/MainMenu.csv Outdated Show resolved Hide resolved

HaSa1002 requested changes Sep 5, 2021

View reviewed changes

HaSa1002 reviewed Sep 5, 2021

View reviewed changes

src/about_authors.gd Outdated Show resolved Hide resolved

HaSa1002 reviewed Sep 5, 2021

View reviewed changes

bodamat force-pushed the about_page branch from ede6271 to 828e236 Compare September 7, 2021 00:24

HaSa1002 requested changes Sep 7, 2021

View reviewed changes

src/addons/Libre_Train_Sim_Editor/Data/Modules/MainMenu.tscn Outdated Show resolved Hide resolved

HaSa1002 reviewed Sep 7, 2021

View reviewed changes

src/addons/Libre_Train_Sim_Editor/Data/Modules/MenuAbout.gd Outdated Show resolved Hide resolved

Add about page

7a90aee

bodamat force-pushed the about_page branch from 7a5875b to 7a90aee Compare September 7, 2021 10:12

HaSa1002 approved these changes Sep 7, 2021

View reviewed changes

Jean28518 merged commit 485780e into Libre-TrainSim:master Sep 14, 2021

HaSa1002 mentioned this pull request Sep 16, 2021

Add About Page #124

Closed

nalquas added the ux Usability and Expierience issues. label Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

About page #128

About page #128

bodamat commented Sep 4, 2021 •

edited

Loading

bodamat commented Sep 4, 2021

bodamat commented Sep 4, 2021

HaSa1002 commented Sep 5, 2021

HaSa1002 left a comment

HaSa1002 Sep 5, 2021

bodamat Sep 5, 2021

HaSa1002 Sep 5, 2021

bodamat Sep 5, 2021

bodamat commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

bodamat commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021 •

edited

Loading

bodamat commented Sep 5, 2021 •

edited

Loading

HaSa1002 commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021 via email •

edited

Loading

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 left a comment

HaSa1002 Sep 5, 2021

bodamat Sep 5, 2021

HaSa1002 Sep 5, 2021

bodamat Sep 5, 2021

HaSa1002 Sep 5, 2021

bodamat Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

bodamat commented Sep 7, 2021

HaSa1002 left a comment

HaSa1002 left a comment

Jean28518 commented Sep 14, 2021

	export(Resource) var authours = authours as Authors
	export(Resource) var authors

	export(Resource) var authours = authours as Authors
	export(Resource) var authors = null

About page #128

About page #128

Conversation

bodamat commented Sep 4, 2021 • edited Loading

bodamat commented Sep 4, 2021

bodamat commented Sep 4, 2021

HaSa1002 commented Sep 5, 2021

HaSa1002 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bodamat commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

bodamat commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021 • edited Loading

bodamat commented Sep 5, 2021 • edited Loading

HaSa1002 commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021 via email • edited Loading

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

bodamat commented Sep 5, 2021

HaSa1002 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bodamat commented Sep 5, 2021

HaSa1002 commented Sep 5, 2021

Rebase

Soft reset

bodamat commented Sep 7, 2021

HaSa1002 left a comment

Choose a reason for hiding this comment

HaSa1002 left a comment

Choose a reason for hiding this comment

Jean28518 commented Sep 14, 2021

bodamat commented Sep 4, 2021 •

edited

Loading

HaSa1002 commented Sep 5, 2021 •

edited

Loading

bodamat commented Sep 5, 2021 •

edited

Loading

HaSa1002 commented Sep 5, 2021 via email •

edited

Loading