Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor menus #133

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Refactor menus #133

merged 2 commits into from
Oct 14, 2021

Conversation

HaSa1002
Copy link
Member

@HaSa1002 HaSa1002 commented Sep 5, 2021 •
edited
Loading

The current UI and menu setup is relativly unflexible and hard to maintain.

Apart that, there are a couple of things, I changed or added:

  1. A new theme (see below)
  2. Pack loading is done in seperate script
  3. Settings to the pause menu
  4. Automatic font sizing depending on mobile or desktop version
  5. Automatic detection of mobile version
  6. A loading screen
Images

content menu
about menu
main menu
pause menu

Tasks

  • Unify mobile and desktop UI where only text size is changed.
  • Add AutoDynamicFont changing size depending on device
  • Split HUD into mutliple scripts and scenes
  • Replace a lot fonts
  • Fix the remaining fonts
  • Split main menu into multiple scenes and scripts
  • Make files snake_case
  • Clean up git history
  • Finish theme

Fixes #126
Depends on: #144

@HaSa1002 HaSa1002 force-pushed the refactor-ui branch 7 times, most recently from 93e7877 to 1777bfe Compare October 2, 2021 14:24
@HaSa1002 HaSa1002 marked this pull request as ready for review October 2, 2021 14:24
@HaSa1002
Copy link
Member Author

HaSa1002 commented Oct 2, 2021

ready for review

This was referenced Oct 2, 2021
Merged
Closed
Merged
DasCapschen
DasCapschen reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@DasCapschen DasCapschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good :)

src/addons/Libre_Train_Sim_Editor/Data/Modules/SettingsMenu.tscn Outdated Show resolved Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Modules/UI/loading_screen.gd Show resolved Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Modules/main_menu.gd Outdated Show resolved Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Scripts/RailMap.gd Outdated Show resolved Hide resolved
@HaSa1002
Copy link
Member Author

HaSa1002 commented Oct 3, 2021

fixed comments

@HaSa1002
Copy link
Member Author

HaSa1002 commented Oct 3, 2021

rebased

@HaSa1002 HaSa1002 added the enhancement New feature or request label Oct 12, 2021
@HaSa1002 HaSa1002 added this to In progress in v0.9 (Old) via automation Oct 12, 2021
@HaSa1002 HaSa1002 added this to the 0.9 milestone Oct 12, 2021
@HaSa1002
Refactor menus
1eaddfe 
* Unify mobile and desktop UI where only text size is changed.
* Add AutoDynamicFont changing size depending on device
* Split HUD into mutliple scripts and scenes
* Replace a lot fonts
@HaSa1002
Ensure jSettings is always on top
85b5171
@HaSa1002
Copy link
Member Author

rebased

@HaSa1002 HaSa1002 mentioned this pull request Oct 13, 2021
Open
@DasCapschen DasCapschen merged commit 2510114 into Libre-TrainSim:master Oct 14, 2021
v0.9 (Old) automation moved this from In progress to Done Oct 14, 2021
@HaSa1002 HaSa1002 deleted the refactor-ui branch October 30, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasCapschen DasCapschen DasCapschen left review comments

@Jean28518 Jean28518 Awaiting requested review from Jean28518

Assignees

@HaSa1002 HaSa1002

Labels
enhancement New feature or request
Projects
No open projects
v0.9 (Old)
  
Done
Milestone
0.9 (Old)
Development

Successfully merging this pull request may close these issues.

In-Game Options Menu
2 participants
@HaSa1002 @DasCapschen