Fix stolen mouse input in editor #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaSa1002
added
the
editor
HaSa1002
force-pushed
the
fix-stolen-input
branch
from
ca9e0a7
to
99831eb
Compare
|
quick question: how are mouse clicks handled now in 3D view? Via unhandled input? |
|
So the camera has its own handling in _unhandled_input. Most of the actions are in _unhandled_input as well, except for the dragging. The drag start should be in _unhandled_input. The dragging itself in _input. (I hope I changed it to this logic. Can't remember right now 😅). The selctions will be handled by the physics engine as soon, as this is fixed. Maybe through a signal by the camera, but idk yet tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
Fixes #180