Add Highlight postprocessing to Editor selection (remove bouncing animation) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaSa1002
added
editor
|
I'd be in favor of only using the outline shader because the tint makes it hard to match colors. |
HaSa1002
requested changes
Oct 31, 2021
src/addons/Libre_Train_Sim_Editor/Data/Modules/Postprocess/LaplaceEdgeDetect.gdshader
Outdated
Show resolved
Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Modules/Postprocess/ShaderPP.gd
Outdated
Show resolved
Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Modules/Postprocess/ShaderPP.gd
Outdated
Show resolved
Hide resolved
src/addons/Libre_Train_Sim_Editor/Data/Modules/Postprocess/highlight_shader.gdshader
Outdated
Show resolved
Hide resolved
DasCapschen
force-pushed
the
add/editor_postprocess
branch
from
9d86d96
to
d4f6d87
Compare
|
I've changed it to only use outlines. |
DasCapschen
force-pushed
the
add/editor_postprocess
branch
from
d4f6d87
to
f1d21e6
Compare
|
rebased |
DasCapschen
force-pushed
the
add/editor_postprocess
branch
from
f1d21e6
to
e6d0c3f
Compare
DasCapschen
force-pushed
the
add/editor_postprocess
branch
from
e6d0c3f
to
e74fd90
Compare
HaSa1002
approved these changes
Nov 5, 2021
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "bouncing" animation from the selected object in Editor, and replaces it with Postprocessing Effects to outline and highlight the object.
This is what it would currently look like:
Of course, we can decide to only use outlines, or only use highlighting (they are 2 separate nodes that added to the Editor scene tree), and the colors are also configurable.
What is currently not configurable, though I'm sure I can work out how to do that, is the thickness of the outline, which is currently only about 2 pixels...