Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert editor maps to mods #228

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Convert editor maps to mods #228

merged 1 commit into from
Nov 7, 2021

Conversation

HaSa1002
Copy link
Member

@HaSa1002 HaSa1002 commented Nov 6, 2021 •
edited
Loading

Resolves #224 and enables U2 and Hainfurt getting loaded in editor

@HaSa1002 HaSa1002 force-pushed the fix-map-loading branch 3 times, most recently from 61e3489 to 6e85eff Compare November 7, 2021 01:16
@HaSa1002 HaSa1002 added breaks-worlds This Issue or PR breaks world loading/editing compatibility. bug Something isn't working editor everthing that belongs to the editor functions of Libre TrainSim modding Mods and modding tools labels Nov 7, 2021
@HaSa1002 HaSa1002 added this to In progress in v0.9 (Old) via automation Nov 7, 2021
@HaSa1002 HaSa1002 added this to the 0.9 milestone Nov 7, 2021
@HaSa1002
Copy link
Member Author

HaSa1002 commented Nov 7, 2021 •
edited
Loading

fix pck export not writing content.tres. Not sure if I did that

DasCapschen
DasCapschen requested changes Nov 7, 2021
View reviewed changes
Copy link
Member

@DasCapschen DasCapschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, but consider comments.

src/Editor/Editor.tscn Show resolved Hide resolved
src/Editor/Scripts/Editor.gd Outdated Show resolved Hide resolved
src/Editor/Scripts/Editor.gd Show resolved Hide resolved
src/Editor/Scripts/Editor.gd Outdated Show resolved Hide resolved
src/Editor/Scripts/Editor.gd Show resolved Hide resolved
src/Editor/Scripts/SelectCollider.gd
else:
mesh = get_parent().mesh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it still work then?
We really need to rework how the select collider works...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. TBH I am sure things broke, but there are less broken now 🤷

src/Editor/Scripts/editor_configuration.gd Outdated Show resolved Hide resolved
@DasCapschen DasCapschen mentioned this pull request Nov 7, 2021
Closed
@HaSa1002 HaSa1002 force-pushed the fix-map-loading branch 2 times, most recently from d6a4112 to 98acfad Compare November 7, 2021 14:54
@HaSa1002
Copy link
Member Author

HaSa1002 commented Nov 7, 2021

rebased

@HaSa1002 HaSa1002 changed the title Fix mod maps not being editable Convert editor maps to mods Nov 7, 2021
DasCapschen
DasCapschen approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@DasCapschen DasCapschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DasCapschen DasCapschen merged commit f864f55 into Libre-TrainSim:master Nov 7, 2021
v0.9 (Old) automation moved this from In progress to Done Nov 7, 2021
@HaSa1002 HaSa1002 deleted the fix-map-loading branch July 31, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasCapschen DasCapschen DasCapschen approved these changes

Assignees
No one assigned
Labels
breaks-worlds This Issue or PR breaks world loading/editing compatibility. bug Something isn't working editor everthing that belongs to the editor functions of Libre TrainSim modding Mods and modding tools
Projects
No open projects
v0.9 (Old)
  
Done
Milestone
0.9 (Old)
2 participants
@HaSa1002 @DasCapschen