Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getPathFromTo #246

Merged
merged 2 commits into from
Nov 16, 2021
Merged

fix getPathFromTo #246

merged 2 commits into from
Nov 16, 2021

Conversation

DasCapschen
Copy link
Member

fixes #203

@DasCapschen DasCapschen added the bug Something isn't working label Nov 12, 2021
@DasCapschen DasCapschen added this to the 0.9 milestone Nov 12, 2021
@DasCapschen DasCapschen self-assigned this Nov 12, 2021
@DasCapschen DasCapschen added this to In progress in v0.9 (Old) via automation Nov 12, 2021
@HaSa1002
Copy link
Member

IMO those connections should be NodePaths

@DasCapschen
Copy link
Member Author

They cannot be NodePaths, because NodePath is always relative to the Node they are saved on, but the path needs to be relative to the Wagon...
Although, I think I can change the code to be relative to the current Node instead of the wagon 🤔

@DasCapschen
Copy link
Member Author

Okay, it is now using NodePaths.

BUT!
I just noticed it is actually still broken.
Passengers never sit down, they only get in the train and then get stuck on some path node.
I mean, it's better than before, where passengers got stuck outside the train, but yeah... :/

HaSa1002
HaSa1002 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@HaSa1002 HaSa1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is better than now. Let's merge it and fix more later :)

HaSa1002
HaSa1002 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@HaSa1002 HaSa1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@HaSa1002 HaSa1002 merged commit b1b7487 into Libre-TrainSim:master Nov 16, 2021
v0.9 (Old) automation moved this from In progress to Done Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaSa1002 HaSa1002 HaSa1002 approved these changes

Assignees

@DasCapschen DasCapschen

Labels
bug Something isn't working
Projects
No open projects
v0.9 (Old)
  
Done
Milestone
0.9 (Old)
Development

Successfully merging this pull request may close these issues.

getPathFromToHelper crash
2 participants
@DasCapschen @HaSa1002