fix vacuum tests

LibreCat · May 23, 2016 · 2fdccf6 · 2fdccf6
1 parent 7dfe14b
commit 2fdccf6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/Build.PL b/Build.PL
@@ -1,5 +1,5 @@
 
-# This file was automatically generated by Dist::Zilla::Plugin::ModuleBuild v5.039.
+# This file was automatically generated by Dist::Zilla::Plugin::ModuleBuild v5.041.
 use strict;
 use warnings;
 

diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 Revision history for Catmandu
 
 {{$NEXT}}
+  - faster, simpler vacuum fix
 
 1.02  2016-05-20 11:33:38 CEST
   - all fixes and fix conditions can be used inline now

diff --git a/lib/Catmandu/Fix/vacuum.pm b/lib/Catmandu/Fix/vacuum.pm
@@ -27,7 +27,7 @@ sub _empty {
 sub fix {
     my ($self, $data) = @_;
 
-    return $data unless is_hash_ref($data) || is_array_ref($data);
+    return $data unless $self->_visit($data);
 
     my @stack = ($data);
     my %seen;

diff --git a/t/Catmandu-Fix-vacuum.t b/t/Catmandu-Fix-vacuum.t
@@ -21,7 +21,7 @@ BEGIN {
     use_ok $pkg;
 }
 
-my $res = $pkg->new()->fix(
+my $res = $pkg->new->fix(
     {
         arrays         => [],
         hashes         => {},
@@ -34,7 +34,7 @@ my $res = $pkg->new()->fix(
     }
 );
 
-is_deeply $res, {keep_me => {me => 1}, keep_me_2 => [undef, [":-P yuck"]]},
+is_deeply $res, {keep_me => {me => 1}, keep_me_2 => [[":-P yuck"]]},
     "data is vacuumed";
 
-done_testing 2;
+done_testing;