New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce a new fix map to move several fields by a lookup table #366
Conversation
this one solves #67 |
…/new-fix-map * 'pr/new-fix-map' of github.com:LibreCat/Catmandu: introduce a new fix map to move several fields by a lookup table
I'd like to rename this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapping is indeed better, looks good otherwise
name of fix changed from map to mapping |
The tests fail for perl version 5.10 and 5.12, because one dependency module requires at least perl 5.14. Should we move on from these two versions? |
The failure was not caused by this PR but by #379 |
I'd make deletion optional with option |
@nichtich delete option could be misinterpreted by users: it could mean "delete all fields not in the mapping table" (as we use it in the lookup fix). Maybe find another option name? |
How about `keep` to not delete anything?
|
in analogy the the lookup fix: this one lookups up in the table and moves the fields instead of changing the values.