Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a new fix map to move several fields by a lookup table #366

Merged
merged 6 commits into from Sep 17, 2021

Conversation

vpeil
Copy link
Member

@vpeil vpeil commented May 23, 2019

in analogy the the lookup fix: this one lookups up in the table and moves the fields instead of changing the values.

@vpeil vpeil requested a review from nics May 23, 2019 18:19
@vpeil
Copy link
Member Author

vpeil commented May 23, 2019

this one solves #67

vpeil added 2 commits May 23, 2019 20:40
…/new-fix-map

* 'pr/new-fix-map' of github.com:LibreCat/Catmandu:
  introduce a new fix map to move several fields by a lookup table
@coveralls
Copy link

coveralls commented May 23, 2019

Coverage Status

Coverage decreased (-0.01%) to 89.256% when pulling ef75f18 on pr/new-fix-map into 7c4c05d on dev.

@nichtich
Copy link
Member

I'd like to rename this to mapping because map more likely refers to an individual row. We have fixes marc_map and pica_map, these could be extended with fixes marc_mapping and pica_mapping similar to this new fix. ok?

Copy link
Member

@nics nics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping is indeed better, looks good otherwise

@vpeil
Copy link
Member Author

vpeil commented Sep 15, 2021

mapping is indeed better, looks good otherwise

name of fix changed from map to mapping

@vpeil
Copy link
Member Author

vpeil commented Sep 15, 2021

The tests fail for perl version 5.10 and 5.12, because one dependency module requires at least perl 5.14. Should we move on from these two versions?

@nichtich
Copy link
Member

The failure was not caused by this PR but by #379

@nichtich
Copy link
Member

I'd make deletion optional with option delete: 0 (default: 1) so you can also copy instead of rename.

@vpeil
Copy link
Member Author

vpeil commented Sep 16, 2021

I'd make deletion optional with option delete: 0 (default: 1) so you can also copy instead of rename.

@nichtich delete option could be misinterpreted by users: it could mean "delete all fields not in the mapping table" (as we use it in the lookup fix). Maybe find another option name?

@nichtich
Copy link
Member

nichtich commented Sep 16, 2021 via email

@vpeil
Copy link
Member Author

vpeil commented Sep 17, 2021

@nics @nichtich Anything else that prevents it from a merge?

@nics nics merged commit 0bb0b2b into dev Sep 17, 2021
@nics nics deleted the pr/new-fix-map branch September 17, 2021 06:58
@nics nics mentioned this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants