-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg-config: prefix sysroot path #1135
Conversation
I've clean built RPi/RPi2/Generic with this on LE master + Kodi master, and all seems well - no build failures, no missing or extra files, systems boot OK etc. Edit: All of the builds included all PVR and inputstream addons. |
Jenkins is happy, I think we can shove this in |
No issues from me, but this is currently labelled LE9. |
@MilhouseVH feel free to change :) |
Removed LE9 label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RPi/RPi2/Generic all seem fine.
Added my approval based on my testing, but will leave the button pushing to chewitt as this will affect the beta. If chewitt doesn't want this for LE8 then we can add back the LE9 label. |
This PR makes cmake set sysroot prefixed
<package>_INCLUDE_DIRS
and other variables when a package is found by pkg-config.This adds a patch to pkg-config that changes the following behaviors:
PKG_CONFIG_ALLOW_SYSTEM_(CFLAGS|LIBS)
.pc
-file already contains a sysroot prefixed pathincludedir
andlibdir
variables, they are usually added to cmake<package>_(INCLUDE_DIRS|LIBRARIES)
Needs more build and runtime testing for non-cmake packages.