kodi: Add peak3d's amltiming patch #1149
Conversation
|
Patch will probably work for Amlogic devices using kernel 3.10. But the Kernel patch needs to be rebased. |
|
As @chewitt was talking about in the Slack chat, I think both these PR's should go into the next LE release ASAP to get wider AML LE testing under way with a larger number of test guinea pigs ;-) Fractional video playback is already pretty nice from my viewing perspective. |
|
Kernel PR for 3.10: LibreELEC/linux-amlogic#35 |
|
this seems to include xbmc/xbmc#10887 so be careful. cc @codesnake |
|
No @stefansaraev. He closed that PR because he reworked it. These are @peak3d's recent commits which he kindly rebased for Krypton. |
|
I know what happened, but this still feels to me a bit too much intrusive for krypton. it's not ok to treat krypton (v17, rc, stable, whatever) users as guinea pigs. you are too late for v17. next LE (kodi v18) is where this should be tested.. of course it's up to you, this is just my personal opinion. |
|
It's not up to me btw @stefansaraev. I'm not a LE Teammember. I was just asked by chewitt to PR it. I've asked to add "Don't merge" label. I've got some good feedback in my community build. Krypton Amlogic is broken anyway for various videos, might it be annoying stutter for various mpeg2 files, blackscreen issues for flv files etc. |
|
I meant up to the team, and it's a fair warning :) |
|
http://sprunge.us/NihD (url edited) here. you may need to rework as project specific override. this was added for very good reason in krypton. (mpeg2 was also broken in jarvis and pre..) |
|
Not sure what you mean. |
|
If these changes do not make it into LE Krypton then expect a AML LE user community backlash, yes even from the guinea pigs. There is so much AML video sync, deinterlacing and general video playback broken without including them that any AML LE Krypton releases IMHO will be useless. Personally I would rather see them included than not, yes even at this late hour. Yes I know the LE codefreeze release rules. |
|
Long time AML "guinea pig" here, just throwing in my 2 cts ;-) I tested the versions from @Raybuntu including the patches from @peak3d, and this was the first time krypton on the Odroid C2 was usable/enjoyable. Without this PR LE8 on the c2 is -at least for my usecases- not in a state where it should be shipped. |
|
also please don't forget about new patch peak3d/xbmc@087c11d |
|
@Goga777: This PR was already rebased 10 hours ago, don't worry. |
|
Made custom Krypton build with these patches for s905x.. They make a great improvement.. without this many videos were unwatchable. |
Ray-future
changed the title
There was a problem hiding this comment.
Adding this goes against our commitment to reduce patches, but there is no upstream plan to backport this to Krypton and without it Amlogic playback on Krypton is unfit for release. These changes have tested well, and we will continue to directly assist the creator with efforts to refine Kodi Amlogic support.
Recent @peak3d's patch for Kodi Krypton for smooth 24p playback. Fixes various playback issue.
This is still WIP, please do not merge.
It only works with the linux patch:
LibreELEC/linux-amlogic#34
LibreELEC/linux-amlogic#35
Original work: https://github.com/peak3d/xbmc/pull/2