Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update samba url to https #1214

Merged
merged 2 commits into from Jan 27, 2017
Merged

update samba url to https #1214

merged 2 commits into from Jan 27, 2017

Conversation

sopparus
Copy link
Contributor

doesnt fetch without https at the moment and build halts

doesnt fetch without https at the moment and build halts
@MilhouseVH
Copy link
Contributor

MilhouseVH commented Jan 26, 2017

No real objection to the https change, but can you post the actual download error you are experiencing - I'm testing the http url here and it redirects to https, so the download succeeds...

neil@nm-linux:~/projects$ wget --passive-ftp --no-check-certificate -c -O /tmp/test.tar.gz http://samba.org/samba/ftp/stable/samba-3.6.25.tar.gz
URL transformed to HTTPS due to an HSTS policy
--2017-01-26 23:18:24--  https://samba.org/samba/ftp/stable/samba-3.6.25.tar.gz
Resolving samba.org (samba.org)... 144.76.82.156, 2a01:4f8:192:486::443:2
Connecting to samba.org (samba.org)|144.76.82.156|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://www.samba.org/samba/ftp/stable/samba-3.6.25.tar.gz [following]
--2017-01-26 23:18:24--  https://www.samba.org/samba/ftp/stable/samba-3.6.25.tar.gz
Resolving www.samba.org (www.samba.org)... 144.76.82.156, 2a01:4f8:192:486::443:2
Connecting to www.samba.org (www.samba.org)|144.76.82.156|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://download.samba.org/pub/samba/stable/samba-3.6.25.tar.gz [following]
--2017-01-26 23:18:24--  https://download.samba.org/pub/samba/stable/samba-3.6.25.tar.gz
Resolving download.samba.org (download.samba.org)... 144.76.82.156, 2a01:4f8:192:486::443:2
Connecting to download.samba.org (download.samba.org)|144.76.82.156|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 34121828 (33M) [application/gzip]
Saving to: ‘/tmp/test.tar.gz’

/tmp/test.tar.gz                100%[===============================>]  32.54M  2.32MB/s    in 14s

2017-01-26 23:18:38 (2.31 MB/s) - ‘/tmp/test.tar.gz’ saved [34121828/34121828]

neil@nm-linux:~/projects$

@sopparus
Copy link
Contributor Author

yep the redirect works now, guess it was just broken a few hours ago then. Close or merge, you decide :)

@MilhouseVH
Copy link
Contributor

I think we'll merge, I was just more intrigued by why it had suddenly become an issue. Also, if ever the tarball is not available from the package url it should always be available from the LE mirror, but unfortunately that server is offline right now. So a combination of two issues (no redirect and no backup mirror) would halt your build.

@MilhouseVH
Copy link
Contributor

@sopparus would you mind adding the same change for ccache as a second commit on each of your PRs?

@sopparus
Copy link
Contributor Author

done

@MilhouseVH
Copy link
Contributor

Many thanks!

@MilhouseVH MilhouseVH merged commit 7184ad3 into LibreELEC:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants