New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux configs: cleanup #1528
linux configs: cleanup #1528
Conversation
wy would amlogic hardware need CONFIG_FB_MODE_HELPERS ? |
As mentioned, because of #1087 - CONFIG_FB_MODE_HELPERS=y is now a default. (Perhaps the question is why has CONFIG_FB_UDL been enabled for amlogic?) |
yep. I doubt CONFIG_FB_UDL works or has any use case on amlogic. EDIT: I dont think it works on rpi either, but well.. however |
OK I'll remove it from WeTek_* and update. Thanks. |
Updated. |
Not sure about that, as it remains enabled upstream: https://github.com/raspberrypi/linux/blob/64845d8fcca13b82762e2637228a3f32f6f41420/arch/arm/configs/bcm2709_defconfig#L842 Ping @popcornmix |
I believe CONFIG_FB_UDL does work for console framebuffer on pi, but not for firmware driven openGL ES. So I don't believe anyone would car if removed for LE. |
i dont know why for RPI they this enabled but that was here #1087 |
@nahun are you actually using USB display link display with LE on Pi? |
i just got USB-C adapter to HDMI but i got error [ 4341.650172] pcieport 0000:00:1c.0: AER: Corrected error received: id=00e0 i will check if some other config kernel changes are needed |
the stupid thing only makes sense on x86 with drm/x11 and good usb3 usb controller. just remove it. |
No I couldn't get it to work, definitely can be removed. |
i tested again on cold boot with connected USB-C adapter and boots fine with picture on screen :) "[ 54.417539] [drm:intel_dp_read_desc] DP branch: OUI 00-1c-f8 dev-ID 171GB0 HW-rev 0.1 SW-rev 15.29" |
Updated with additional commit dropping FB_UDL from RPi/RPi2/Odroid_C2/imx6.
This leaves FB_UDL enabled only for Generic. @piotrasd you commented on #1087:
Is DRM_UDL=m still required for FB_UDL to work on Generic? Currently DRM_UDL is not set, do you have it enabled in your build? |
i will confirm by check official Generic build |
after test on latest official LE 8.0.1 where "DRM_UDL is not set" - USB-C to HDMI adapter working ;) |
Rebased after #1533. |
as it causes connection issues with different gamepads, it is safer to remove it and the user can add this on need basis via ``` echo options bluetooth disable_ertm=1 > /storage/.config/modprobe.d/disable_ertm.conf ``` fixes LibreELEC#1528
I've run
make oldconfig
on all projects and accepted the defaults.These are the differences:
CONFIG_FB_MODE_HELPERS=y
which is selected byCONFIG_FB_UDL
in config: ADD CONFIG_FB_UDL module (USB displaylink) #1087CONFIG_INITRAMFS_ROOT_UID
etc.)Would be good if all project maintainers could take a look and comment if they have any concerns.
I'll include these changes in RPi/RPi2/Generic test builds - if no issues/concerns, merge in a week or so?