Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: bump LE settings add-on to 9.0.0 #1565

Merged
merged 1 commit into from Apr 25, 2017

Conversation

HiassofT
Copy link
Member

Use updated methods of starting/stopping lircd after #1320 lirc changes

@MilhouseVH
Copy link
Contributor

Careful, as this will pull in the smbd/nmbd change (LibreELEC/service.libreelec.settings#62) which has a dependency on #1469...

@HiassofT
Copy link
Member Author

phew. Then how should we go with that? The LE settings changes from settings PR 63 are required for the lirc changes that are now in master.

@MilhouseVH
Copy link
Contributor

Options:

  1. Go full steam ahead on Samba4 with all it's niggling problems, and merge samba: update to samba-4.x #1469.

  2. Revert change smbd and nmbd location service.libreelec.settings#62 and rebase this PR, which buys us more time to ponder Samba4 (I can resubmit the smbd/nmbd PR if/when necessary).

I'm cool with either option. Ping @chewitt, @lrusak.

@HiassofT
Copy link
Member Author

option 2 seems to be safest to me

@HiassofT
Copy link
Member Author

@chewitt @lrusak could you please merge settings PR 64, then I'll update this PR with the new hash.
LibreELEC/service.libreelec.settings#64

@MilhouseVH
Copy link
Contributor

Oops sorry didn't see you'd asked chewitt/lrusak. My bad.

@HiassofT
Copy link
Member Author

Updated PR with new git hash (LE settings without Samba changes)

@chewitt chewitt merged commit d39db0d into LibreELEC:master Apr 25, 2017
@HiassofT HiassofT deleted the le-settings-lirc branch September 5, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants