addons: remove duplicated install code #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewitt
reviewed
Jul 17, 2017
scripts/install_addon
Outdated
| sed -e "s|@PKG_ADDON_NEWS@||g" -i $ADDON_BUILD/$PKG_ADDON_ID/addon.xml | ||
| fi | ||
|
|
||
| PROVIDER_NAME="libreelec.tv" |
|
Actually, functionality will be changed slightly by this change, hopefully for the better - all installed shared object libraries will now have the executable file permission applied (they don't at the moment, eg. |
|
If no objections, could we get this in before it rots? |
CvH
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to eliminate duplicated code, functionality should remain largely unchanged.
@lrusak I've included the new
scripts/install_addonscript which is currently called only fromscripts/create_addon. Maybe in future this can be expanded upon if we ever need to install addons during the main build.