brcmfmac_sdio-firmware-rpi: Consolidate firmware files #1922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we install:
BCM43430A1.hcd
frombrcmfmac_sdio-firmware-rpi
brcmfmac43430-sdio.bin
fromkernel-firmware
brcmfmac43430-sdio.txt
fromwlan-firmware
This is crazy, particularly as we need to install updated brcmfmac43430-sdio.{bin,txt} (see here) but pulling the files from
kernel-firmware
(a repo not under our control) means that is more difficult to do - yes, we could binary patch it...Now, all three files will be installed from
brcmfmac_sdio-firmware-rpi
.This PR depends on LibreELEC/wlan-firmware#4 (I'll update this once it is merged).
The change to
kernel-firmware
is a hack, but the best I could think of right now.If any non-RPi0/RPi3 platforms require
brcmfmac43430-sdio.{bin,txt}
then this PR is wrong, as we will only be installing these files for RPi/RPi2.This can be backported to libreelec-8.2.