Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/checkdeps: add python #2153

Merged
merged 1 commit into from
Oct 28, 2017
Merged

scripts/checkdeps: add python #2153

merged 1 commit into from
Oct 28, 2017

Conversation

MilhouseVH
Copy link
Contributor

With the meson change we now have a dependency on python before any packages (including our own Python2) are built:

LibreELEC.tv/config/functions

Line 60 in 2a530ac

python -c "import os; print('c_args = {}'.format([x for x in os.getenv('CFLAGS').split()]))" >> $MESON_CONF

Consequently on a system without python (eg. an Ubuntu Xenial Docker), the build will fail with an error.

config/functions: line 60: python: command not found
Makefile:9: recipe for target 'release' failed
make: *** [release] Error 127

Adding python to scripts/checkdeps will avoid this issue.

Ray-future
Ray-future approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@Ray-future Ray-future left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Kwiboo Kwiboo mentioned this pull request Oct 28, 2017
Merged
@Ray-future
Copy link
Contributor

Ray-future commented Oct 28, 2017 •
edited
Loading

Looks like Fedora switched to python3 by default. The package is called python2:
https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3#.2Fusr.2Fbin.2Fpython

ARCH is using python2 metapackage too:
https://wiki.archlinux.org/index.php/python#Python_2

@MilhouseVH
Copy link
Contributor Author

MilhouseVH commented Oct 28, 2017 •
edited
Loading

Knew it wouldn't be so simple... :(

Edit: s/New/Knew/

@MilhouseVH
Copy link
Contributor Author

@Raybuntu updated - how does that look now?

@Ray-future Ray-future merged commit aafe8ef into LibreELEC:master Oct 28, 2017
@Ray-future
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ray-future Ray-future Ray-future approved these changes

Assignees
No one assigned
Labels
BUILDSYSTEM LE 9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MilhouseVH @Ray-future