swig: couple of buildsystem fixes #2181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
libcec
andkodi
on Ubuntu were being built with the build hostswig
(3.0.8 on 16.04, 3.0.10 on 17.10) from/usr/bin
, and not$TOOLCHAIN/bin/swig
which is currently version 3.0.12.The reason for this is that Ubuntu has:
while we only have
$TOOLCHAIN/bin/swig
, andfind_package(SWIG)
inlibcec
(and alsokodi
) is looking for and findingswig3.0
before falling back toswig
, so consequently it ignores our toolchain binary and uses the build-host file.This PR fixes this error by configuring
swig
to create theswig3.0
binary in our toolchain.The
swig
sym link is just for backward compatibility (ie. just in case), same as Ubuntu.Thanks @Raybuntu for looking into this.