scripts/create_addon: simplify PROJECT selection, support DEVICE #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the old code, any addon that is for RPi2 but not RPi, would not build as the PROJECT=RPi, eg. audiodecoder.usf which has:
and scripts/create_addon would then claim that RPi is not supported.
Similarly, service/slice has:
which will work with the old code, building for all RPi-based devices, but I don't know if this is intended. Consequently I've updated this package with the correct device codes, which will now mean it won't build for RPi and RPi2.