New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayland support #2232
wayland support #2232
Conversation
@lrusak : did you try to build this on rockchip ? :) |
Any objections to merge this ? :) |
Some build tests should be done for each display server method |
Questions:
Edit: Changed to |
@@ -0,0 +1,13 @@ | |||
[core] | |||
idle-time=0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rockchip needs repaint-window=15
in [core]
to be able to render at 60 fps, would that hurt other platforms?
For teh record, when i started playing with @lrusak wayland work on rockchip i had to make a few adjustments on rockchip, see https://github.com/LongChair/LibreELEC.tv/commits/rockchip-wayland. Some of these are in this PR but some are not. mostly some X11 dependencies that are not necessarily required for rockchip. Also discussed that with lukas and he said we could maybe make a specific PR to adjust this once this one was merged. |
I tested Kwiboo@de3e4a9 with Kodi on Rockchip and is a mix of both yours (@lrusak and @LongChair) excellent work. The main diff is that it uses This probably need a rebase with recent |
any update on this one ? are we waiting for anything ? |
built successfully for generic. I changed to using DISPLAYSERVER=weston and using the regular cairo package. @LongChair please have another look |
@MilhouseVH can you include this in a test build please? Don't adjust any options. I just want to make sure this doesn't include any regressions for Generic/X11 |
Great work! I've tested this on: Skylake NUC (i915): http://sprunge.us/ANcd and no obvious issues. RPi/RPi2 builds are unaffected (as they should be, but always worth a test build just-in-case). |
Looks good to me too :) |
@@ -22,14 +22,25 @@ | |||
# in Xorg.log | |||
|
|||
PKG_NAME="libepoxy" | |||
PKG_VERSION="1.4.2" | |||
PKG_SHA256="bea6fdec3d10939954495da898d872ee836b75c35699074cbf02a64fcb80d5b3" | |||
PKG_VERSION="1.4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHG_SHA256="0b808a06c9685a62fca34b680abb8bc7fb2fda074478e329b063c1f872b826f6"
is missing
packages/wayland/libinput/package.mk
Outdated
@@ -23,7 +23,7 @@ PKG_ARCH="any" | |||
PKG_LICENSE="GPL" | |||
PKG_SITE="http://www.freedesktop.org/wiki/Software/libinput/" | |||
PKG_URL="http://www.freedesktop.org/software/libinput/$PKG_NAME-$PKG_VERSION.tar.xz" | |||
PKG_DEPENDS_TARGET="toolchain systemd libevdev mtdev" | |||
PKG_DEPENDS_TARGET="toolchain systemd libxkbcommon libevdev mtdev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libinput does not have a build dependency on libxkbcommon, but weston does
PKG_SECTION="wayland" | ||
PKG_SHORTDESC="Specifications of extended Wayland protocols" | ||
PKG_LONGDESC="Specifications of extended Wayland protocols" | ||
PKG_TOOLCHAIN="autotools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be no need for autoreconf?
packages/wayland/wayland/package.mk
Outdated
PKG_SECTION="wayland" | ||
PKG_SHORTDESC="a display server protocol" | ||
PKG_LONGDESC="a display server protocol" | ||
PKG_AUTORECONF="yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PKG_AUTORECONF
is no more, and since there is no patch autoreconf is not really needed
################################################################################ | ||
|
||
PKG_NAME="waylandpp" | ||
PKG_VERSION="0.1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.6 is out and 0.1.5 included some kodi fixes
packages/wayland/weston/package.mk
Outdated
PKG_SECTION="wayland" | ||
PKG_SHORTDESC="Reference implementation of a Wayland compositor" | ||
PKG_LONGDESC="Reference implementation of a Wayland compositor" | ||
PKG_AUTORECONF="yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PKG_AUTORECONF
can be removed
I made a few fixup commits to fix some smaller stuff at Kwiboo/LibreELEC.tv@c4b531f...wayland-fixes |
This is only valid for X11 for now
Allows X11 / Wayland support depending on DISPLAYSERVER
This disables glx support if we don't have X11 and allows to use GLES drivers if we have any.
updated and forced pushed |
@Kwiboo : any more comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No move comments from me, LGTM.
Same here 👍 |
This is basically useless and adds nothing to LE but some people want it to test with.
You need to build with the following options
There is no nvidia support.
I am going to build this now so I'll find out if all the updates and rebasing works or not