Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland support #2232

Merged
merged 17 commits into from Dec 18, 2017
Merged

wayland support #2232

merged 17 commits into from Dec 18, 2017

Conversation

lrusak
Copy link
Member

@lrusak lrusak commented Nov 17, 2017

This is basically useless and adds nothing to LE but some people want it to test with.

You need to build with the following options

OPENGL="no"
OPENGLES="mesa"
DISPLAYSERVER="wayland"
GRAPHIC_DRIVERS="r300 r600 radeonsi i915 i965 vmware virtio"

There is no nvidia support.

I am going to build this now so I'll find out if all the updates and rebasing works or not

@lrusak lrusak added the LE 9.0 label Nov 17, 2017
@LongChair
Copy link
Contributor

@lrusak : did you try to build this on rockchip ? :)

@LongChair
Copy link
Contributor

Any objections to merge this ? :)

@lrusak
Copy link
Member Author

lrusak commented Nov 24, 2017

Some build tests should be done for each display server method

@Kwiboo
Copy link
Member

Kwiboo commented Nov 24, 2017

Questions:

  1. Why not use DISPLAYSERVER="weston" and remove the special wayland-weson handling?
  2. Why isn't the existing cairo package used instead of the special cairo-weston package?

Edit: Changed to DISPLAYSERVER="weston"

@@ -0,0 +1,13 @@
[core]
idle-time=0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rockchip needs repaint-window=15 in [core] to be able to render at 60 fps, would that hurt other platforms?

@LongChair
Copy link
Contributor

For teh record, when i started playing with @lrusak wayland work on rockchip i had to make a few adjustments on rockchip, see https://github.com/LongChair/LibreELEC.tv/commits/rockchip-wayland.

Some of these are in this PR but some are not. mostly some X11 dependencies that are not necessarily required for rockchip.

Also discussed that with lukas and he said we could maybe make a specific PR to adjust this once this one was merged.

@Kwiboo
Copy link
Member

Kwiboo commented Nov 24, 2017

I tested Kwiboo@de3e4a9 with Kodi on Rockchip and is a mix of both yours (@lrusak and @LongChair) excellent work.

The main diff is that it uses DISPLAYSERVER="weston" since the cairo package already checked for weston and also bumped the existing cairo, libinput and libxkbcommon to newest versions.

This probably need a rebase with recent PKG_TOOLCHAIN changes before it can be merged.

@LongChair
Copy link
Contributor

any update on this one ? are we waiting for anything ?

@lrusak
Copy link
Member Author

lrusak commented Dec 13, 2017

built successfully for generic. I changed to using DISPLAYSERVER=weston and using the regular cairo package.

@LongChair please have another look

@lrusak
Copy link
Member Author

lrusak commented Dec 13, 2017

@MilhouseVH can you include this in a test build please? Don't adjust any options. I just want to make sure this doesn't include any regressions for Generic/X11

@MilhouseVH
Copy link
Contributor

Great work!

I've tested this on:

Skylake NUC (i915): http://sprunge.us/ANcd
Revo 3700 (Nvidia ION2): http://sprunge.us/VUTC

and no obvious issues.

RPi/RPi2 builds are unaffected (as they should be, but always worth a test build just-in-case).

@LongChair
Copy link
Contributor

Looks good to me too :)

@@ -22,14 +22,25 @@
# in Xorg.log

PKG_NAME="libepoxy"
PKG_VERSION="1.4.2"
PKG_SHA256="bea6fdec3d10939954495da898d872ee836b75c35699074cbf02a64fcb80d5b3"
PKG_VERSION="1.4.3"
Copy link
Member

@Kwiboo Kwiboo Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHG_SHA256="0b808a06c9685a62fca34b680abb8bc7fb2fda074478e329b063c1f872b826f6" is missing

@@ -23,7 +23,7 @@ PKG_ARCH="any"
PKG_LICENSE="GPL"
PKG_SITE="http://www.freedesktop.org/wiki/Software/libinput/"
PKG_URL="http://www.freedesktop.org/software/libinput/$PKG_NAME-$PKG_VERSION.tar.xz"
PKG_DEPENDS_TARGET="toolchain systemd libevdev mtdev"
PKG_DEPENDS_TARGET="toolchain systemd libxkbcommon libevdev mtdev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libinput does not have a build dependency on libxkbcommon, but weston does

PKG_SECTION="wayland"
PKG_SHORTDESC="Specifications of extended Wayland protocols"
PKG_LONGDESC="Specifications of extended Wayland protocols"
PKG_TOOLCHAIN="autotools"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no need for autoreconf?

PKG_SECTION="wayland"
PKG_SHORTDESC="a display server protocol"
PKG_LONGDESC="a display server protocol"
PKG_AUTORECONF="yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PKG_AUTORECONF is no more, and since there is no patch autoreconf is not really needed

################################################################################

PKG_NAME="waylandpp"
PKG_VERSION="0.1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.6 is out and 0.1.5 included some kodi fixes

PKG_SECTION="wayland"
PKG_SHORTDESC="Reference implementation of a Wayland compositor"
PKG_LONGDESC="Reference implementation of a Wayland compositor"
PKG_AUTORECONF="yes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PKG_AUTORECONF can be removed

@Kwiboo
Copy link
Member

Kwiboo commented Dec 13, 2017

I made a few fixup commits to fix some smaller stuff at Kwiboo/LibreELEC.tv@c4b531f...wayland-fixes

@lrusak
Copy link
Member Author

lrusak commented Dec 16, 2017

updated and forced pushed

@LongChair
Copy link
Contributor

@Kwiboo : any more comments?

Copy link
Member

@Kwiboo Kwiboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No move comments from me, LGTM.

@LongChair
Copy link
Contributor

Same here 👍

@CvH CvH merged commit 31a943b into LibreELEC:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants