Add a possibility to create multi-image device tree blobs for Amlogic #2286
Conversation
| @@ -0,0 +1,35 @@ | |||
| ################################################################################ | |||
| # This file is part of LibreELEC - https://libreelec.tv | |||
| # Copyright (C) 2016 Team LibreELEC | |||
There was a problem hiding this comment.
Copyright (C) 2016-present Team LibreELEC
| PKG_SECTION="tools" | ||
| PKG_SHORTDESC="AML DTB Tools" | ||
| PKG_LONGDESC="AML DTB Tools" | ||
| PKG_AUTORECONF="no" |
There was a problem hiding this comment.
PKG_AUTORECONF="no" is dropped entirely
maybe you need to add PKG_TOOLCHAIN="manual" if it won't compile without
There was a problem hiding this comment.
PKG_TOOLCHAIN is not needed but PKG_AUTORECONF needs to be dropped
| ################################################################################ | ||
|
|
||
| PKG_NAME="aml-dtbtools" | ||
| PKG_VERSION="cce100f" |
There was a problem hiding this comment.
needs PKG_SHA256="8bcaa83fcc9e85c9c04930e7411447d96a97da0809c5ecd9af91c8b554133c41"
There was a problem hiding this comment.
Checksums aren't reliable when using github archives, they get regenerated at random intervals.
| PKG_ARCH="any" | ||
| PKG_LICENSE="free" | ||
| PKG_SITE="https://github.com/Wilhansen/aml-dtbtools" | ||
| PKG_URL="${PKG_SITE}/archive/${PKG_VERSION}.tar.gz" |
There was a problem hiding this comment.
sticking with conventions this should be PKG_URL="https://github.com/Wilhansen/aml-dtbtools/archive/${PKG_VERSION}.tar.gz"
There was a problem hiding this comment.
I know that is the convention, but I think that @kszaq way should be the new convention. Now that we are using github as preferred source, makes more easy use another repository, avoid the mistake of changing the PKG_SITE and not the PKG_URL or vice-versa.
There was a problem hiding this comment.
This is why PR's have reviews so mistakes don't get made :) I don't think this is a good idea, it would add fragmentation as only 300/700 packages use github.
There was a problem hiding this comment.
PKG_SITE is not necessarily github even if the download comes from github. Proper fix would be a special var for gh archives. But not too sure we should add complexity to that.
… Wilhansen for creating the tool
…t it's generated automatically
|
Thank you everyone for reviewing. Suggestions applied. |
|
Thanks @kszaq. Looks good so far I will include that PR in my tree/build to test WP2 and WH. |
|
Looks spot on now, tested against S905 and no problems, haven't tested other projects. |
This is useful if a few devices need to be supported by one project.
If there is only one device tree created from
KERNEL_UBOOT_EXTRA_TARGETit is appended as-is, e.g. without multidtb tool header.