v4l-utils: cleanup build and add missing keymaps #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using patches to add additional keymaps and change the system rc_maps.cfg wasn't such a good idea, it's hard to maintain and easily breaks on upgrades (rc_maps.cfg usually only gets additional lines added, but that's rather fragile with patch context).
Better add additional keymaps via files and use sed/cat in package.mk to change the config. When installing additional keymaps make sure we don't accidentally overwrite existing ones (eg when they were added upstream).
While we're at it also add the (non-upstreamed) odroid and wetek_hub keymaps - I've generated them with gen_keytables.pl from the v4l-utils tree, using our amlogic-3.14 tree as a source (same method as upstream changes are handled in upstream v4l-utils).
I also factored out creation of multi-keymaps into a separate function so it can be reused to create multiple (eg device specific) multi-keymaps