getedid: adding support for AMD GPUs #2449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
General gripe/suggestion: At some point check_gpu should be taught about "3D controller" alongside VGA - here is one example [1]. I think there are a few other things to grep for - don't recall off-hand. |
|
I kind of agree. Those 'should' generally be used on lapops only, but I tested some things and probably found a way to detect the description of available controllers via 'lshw -c display | grep -i "description"' on my Ubuntu machine. Just need to test if that will work on LE as well. Thanks for the suggestion. Much appreciated. |
|
@DaVukovic any progress on this PR? |
MilhouseVH
reviewed
Apr 26, 2018
| @@ -44,8 +44,8 @@ help() { | |||
|
|
|||
| # check for GPU and store string | |||
| check_gpu() { | |||
| if lspci | grep -i vga | grep -i -q intel ; then | |||
| gpu="intel" | |||
| if lspci | grep -i vga | grep -i -q 'intel\|amd' ; then | |||
There was a problem hiding this comment.
grep -i -q -E 'intel|amd' might be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge yet.
This has to be tested before and for the reason I don't have some AMD GPU, I can't be sure. So please understand this PR as a request for a review.
There's also some issue with kernel 4.14 and kabylake hardware which either should be resolved or we should do changes for not supporting > kabylake. Only if newer hardware has the same problem ofc.