Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: source packages reliably #2469

Merged
merged 1 commit into from
Feb 25, 2018
Merged

tools: source packages reliably #2469

merged 1 commit into from
Feb 25, 2018

Conversation

MilhouseVH
Copy link
Contributor

@MilhouseVH MilhouseVH commented Feb 1, 2018

As mentioned in #2141, package.mk should only ever be sourced with config/options.

I haven't updated tools/repo-tool as I'm not sure if it's still used/how it's used.

Copy link
Contributor

@Ray-future Ray-future left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using repo-tool but I never had any issues with it.

@MilhouseVH
Copy link
Contributor Author

repo-tool should be updated then, as it could break at any time - it just needs someone to add a helper function in the global code section of a package and repo-tool will start complaining about command not found. I'll have a go at updating repo-tool this evening and update this PR.

Copy link
Member

@chewitt chewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, if repo-tool needs changes they can be added in a separate PR

@chewitt chewitt merged commit 5903b06 into LibreELEC:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants