-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crazycat: fix building for Amlogic devices using 3.10 kernel and enable for WeTek_Core #2549
Conversation
Recently introduced patches to include drivers for internal DVB modules can't be used with 3.10 devices. Fix this by providing separate patch directory.
if [ $LINUX = "amlogic-3.10" ]; then | ||
PKG_PATCH_DIRS="amlogic-3.10" | ||
elif [ $LINUX = "amlogic-3.14" ]; then | ||
PKG_PATCH_DIRS="amlogic-3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better left for 3.14 PKG_PATCH_DIRS="amlogic". There will be less changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rename it amlogic-$version
, amlogic
is a bit misleading and is not needed at all (hopefully) if we get mainline linux support some day.
Ofc it basically does not matter if we do this this or that way, but as this patches are heavily depending at the used kernel, it isn't wrong.
it looks okay, I have no hw so I can't test it runtime at all (@codesnake should be able to) |
@CvH This is runtime-tested on S805 device. As it's not in LE master, I asked @codesnake for review using W Core. |
PR's for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kszaq Thanks for you PR. It boots OK on my WeTek Core with both base and crazycat drivers. But when I connect my Mygica T230 DVB adapter I get the following errors:
[ 239.356830@2] [amlogic_cec] dump: msg TX len: 1 dat: 10
[ 240.947067@0] usb 1-1.3: new high-speed USB device number 6 using dwc_otg
[ 241.047652@0] usb 1-1.3: config 1 interface 0 altsetting 0 bulk endpoint 0x86 has invalid maxpacket 188
[ 241.049341@0] usb 1-1.3: string descriptor 0 malformed (err = -61), defaulting to 0x0409
[ 241.055095@0] usb 1-1.3: New USB device found, idVendor=0572, idProduct=c688
[ 241.055187@0] usb 1-1.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 241.061661@0] dvb-usb: found a 'Mygica T230 DVB-T/T2/C' in warm state.
[ 241.309868@2] dvb-usb: will pass the complete MPEG2 transport stream to the software demuxer.
[ 241.310096@0] dvbdev: DVB: registering new adapter (Mygica T230 DVB-T/T2/C)
[ 241.326799@2] si2168: Unknown symbol i2c_del_mux_adapter (err 0)
[ 241.326820@2] si2168: Unknown symbol i2c_add_mux_adapter (err 0)
[ 241.329345@2] dvb-usb: no frontend was attached by 'Mygica T230 DVB-T/T2/C'
[ 241.329585@2] Registered IR keymap rc-total-media-in-hand-02
[ 241.331379@2] si2168: Unknown symbol i2c_del_mux_adapter (err 0)
[ 241.331398@2] si2168: Unknown symbol i2c_add_mux_adapter (err 0)
Also the same for Astrometa adapter.
@kszaq To make the above adapters work please enable CONFIG_I2C_MUX=y in WeTek Core kernel config. |
@codesnake Thank you for your review. I have added a kernel update patch, please check if it's OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kszaq. Works good now.
Recently introduced patches to include drivers for internal DVB modules can't be used with 3.10 devices. Fix this by providing separate patch directory.