New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3rd party repositories #2595
Conversation
Signed-off-by: Matthias Reichl <hias@horus.com>
|
LGTM 👍 |
Please don't merge that. The Problem was resolved in the Kodinerds repo. People in charge there have always been responsible and try to resolve those issues ASAP. Let's not burn Bridges with other community projects. As I mentioned on slack. We have more problematic addons in our repo: Oscam. So either close this PR or update the PR to remove linuxserver.io repo and oscam as well. There is no reason for this anymore. |
Signed-off-by: Matthias Reichl <hias@horus.com>
I agree, LibreELEC should stay neutral and not promote the use of select 3rd party repos by giving them a special place within the LibreELEC distribution or repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok now.
15cd791
to
04242bb
Compare
I've dropped the oscan removal commit that I had added before. This PR only focuses on 3rd party repos |
I am against it as it solves no problem and impair the current ootb user experience. Alternatives:
Also I am still unsure what this fixes at all - the initial problem was fixed after 5min and was no real problem at all. This kind of addon would be perfectly fine at the official kodi repo too and I guess we won't remove the official repo if these kind of stuff is added there. There was no single problem at the ls.io repo at all, also removing the only repo that make use of the Docker addon sounds strange. But we should decide the one or the other, currently we ship 3 repos from where 2 are clean and were added as kind of recommendation (ofc not installed by default or enabled). Sry can't see the improvement. At the moment its all about burning bridges to the community to fix problems we never had. |
I can no longer support this change as it is clearly a political change with no real benefit or reason. Therefore I have dismissed my review. |
I'm neither for nor against this but I'm curious why Oscam and all the emulators are not being removed instead/as well as we are actually hosting these 'questionable' add-ons as opposed to just a repository? Just seems like hypocrisy and double standards to me. |
@adamg88 we're trying to focus on one thing at a time - in this PR how to deal with 3rd party repos that are not under our control. Everything else should be handled separately |
Closing for now until final team decision is found how to deal with 3rd party repos |
as discussed on slack, questionable addons were added