Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/image: add BUILDER_NAME, BUILDER_VERSION support #2742

Merged
merged 1 commit into from Jul 8, 2018

Conversation

Projects
None yet
2 participants
@MilhouseVH
Copy link
Contributor

commented Jun 1, 2018

Part of LibreELEC/service.libreelec.settings#100 depends on this.

Updated:
If BUILDER_NAME is present in /etc/os-release, eg. BUILDER_NAME="Milhouse", this value will be included in the url when performing the update check, allowing stats to be aggregated by author.

If BUILDER_VERSION is present in /etc/os-release, eg. BUILDER_VERSION=#0601, this value will be included in the url instead of the normal devel-20180601153228-g89fe123 version that would otherwise be used. This allows stats for the builder to be grouped by a version identifier they are more familiar with (or prefer to use). When using a custom BUILDER_VERSION it's important to include a unique BUILDER_NAME in order to differentiate build statistics with the same version identifier but from different builders.

I'll add the service.libreelec.settings add-on bump to this PR before merging.

@MilhouseVH MilhouseVH changed the title scripts/image: add DISTRO_AUTHOR scripts/image: add DISTRO_AUTHOR support Jun 1, 2018

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:le90_add_AUTHOR branch from 29832ea to 56c462c Jun 2, 2018

@MilhouseVH MilhouseVH changed the title scripts/image: add DISTRO_AUTHOR support scripts/image: add DISTRO_BUILDER support Jun 2, 2018

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2018

Changed it to DISTRO_BUILDER (and in /etc/os-release, BUILDER) as we're not aspiring writers.

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:le90_add_AUTHOR branch from 56c462c to 4ffd33a Jun 2, 2018

@MilhouseVH MilhouseVH changed the title scripts/image: add DISTRO_BUILDER support scripts/image: add BUILDER_NAME, BUILDER_VERSION support Jun 2, 2018

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2018

Add BUILDER_VERSION to simplify stats processing - used as an optional alternative to the existing version when chatting with the update server.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2018

Can be merged now.

@HiassofT HiassofT merged commit 2f5a3b0 into LibreELEC:master Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.