scripts/image: add BUILDER_NAME, BUILDER_VERSION support #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilhouseVH
changed the title
MilhouseVH
changed the title
|
Changed it to |
MilhouseVH
changed the title
|
Add BUILDER_VERSION to simplify stats processing - used as an optional alternative to the existing version when chatting with the update server. |
|
Can be merged now. |
HiassofT
approved these changes
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of LibreELEC/service.libreelec.settings#100 depends on this.
Updated:
If
BUILDER_NAMEis present in/etc/os-release, eg.BUILDER_NAME="Milhouse", this value will be included in the url when performing the update check, allowing stats to be aggregated by author.If
BUILDER_VERSIONis present in/etc/os-release, eg.BUILDER_VERSION=#0601, this value will be included in the url instead of the normaldevel-20180601153228-g89fe123version that would otherwise be used. This allows stats for the builder to be grouped by a version identifier they are more familiar with (or prefer to use). When using a customBUILDER_VERSIONit's important to include a uniqueBUILDER_NAMEin order to differentiate build statistics with the same version identifier but from different builders.I'll add the service.libreelec.settings add-on bump to this PR before merging.