-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: update to 239 #2791
systemd: update to 239 #2791
Conversation
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Assuming busybox, dbus and lirc are happy using /run instead of /var/run, can we add fixup commits in this PR, keeping it all together? |
2ceb53d
to
9490955
Compare
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
/run/utmp is already in systemd's default config, with proper flags (boot only) and permissions, and /var/run is a symlink to /run as per systemd standard so we don't need to list /var/run/utmp in busybox's tmpfiles list. This also removes these systemd boot warnings Line references path below legacy directory /var/run/ Duplicate line for path "/run/utmp", ignoring. Signed-off-by: Matthias Reichl <hias@horus.com>
Signed-off-by: Matthias Reichl <hias@horus.com>
Deprecated /var/run warnings are now fixed. The runstatedir autoconf patch is used by lots of distributions (Debian, Ubuntu, ...), so I decided to add it here as well. The utmp path (default /var/run/utmp) seems to come from glibc / /usr/include/paths.h, not sure if glibc supports changing this. As /var/run is a symlink to /run this is no problem though. |
Update was rather painless, 2 backport patches could be dropped but no further changes were needed to get it built.
Brief runtime test on RPi3B+ is also looking good so far. Systemd now warns about deprecated /var/run entries in tmpfiles.d (from busybox, dbus and lirc), these packages should be fixed and changed to use /run.
An interesting new feature of systemd 239 is the addition of systemd-time-wait-sync, which allows us to delay kodi startup until we got the correct time from NTP. This is especially useful on systems without RTC, like RPi, as a wrong system time will break https (the system time can be before certificate validity start) and thus all update checks run on kodi startup.
A quick test showed that systemd-time-wait-sync works nicely and delayed kodi startup until connman set the systemd time from NTP. So we don't need to use systemd-timesyncd but can keep our connman NTP setup as is.
We'll need to discuss how we best integrate time sync and wait-for-network-online into LE, so I'd like to keep that out of this PR.