Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: drop unused build options #2794

Merged
merged 16 commits into from Jun 28, 2018

Conversation

@CvH
Copy link
Member

CvH commented Jun 24, 2018

configure: WARNING: unrecognized options: --disable-libcurl, --disable-libmms
removed all build options that are not available anymore

python2: creates still a lot of these warnings while compiling some sub libs

sidplay-libs: configure: WARNING: unrecognized options: --disable-library-checks - some error at their code

@CvH

This comment has been minimized.

Copy link
Member Author

CvH commented Jun 24, 2018

How to check:

awk.cfg

/^\s*\033\[.*mBUILD\033\[.*m/ {
  PKG=$2
  TRG=$3
  sub(/^.*\(/, "", TRG)
  sub(/\).*$/, "", TRG)
}

/^configure: WARNING: unrecognized options: --disable-static, --enable-shared$/ { next }
/^configure: WARNING: unrecognized options: --disable-static$/ { next }
/^configure: WARNING: unrecognized options: --enable-shared$/ { next }

/^configure: WARNING: unrecognized options:/ {
  printf "%-20s: %s\n", PKG " (" TRG ")", $0
}

awk -f awk.cfg le-build-output.log

@CvH CvH force-pushed the CvH:9.0-config-drop-crap branch from 1caf661 to 0aeedb5 Jun 26, 2018
@MilhouseVH MilhouseVH merged commit 3e3cc3d into LibreELEC:master Jun 28, 2018
@CvH CvH deleted the CvH:9.0-config-drop-crap branch Jun 28, 2018
@the-dreamer

This comment has been minimized.

Copy link

the-dreamer commented on packages/devel/elfutils/package.mk in 9adf320 Sep 10, 2018

--disable-werror: i think this is breaking compilation on Fedora 28 system. update elfutils to 173 is working again. I assume because of fixing it in that version.

This comment has been minimized.

Copy link
Contributor

MilhouseVH replied Sep 10, 2018

There is no such option as --disable-werror...

configure: WARNING: unrecognized options: --disable-static, --enable-shared, --disable-werror, --disable-progs

The custom support for --disable-werror was added by a "portability" patch dropped almost 3 years ago: OpenELEC/OpenELEC.tv@f574a01#diff-0d93a8d8416c1207ac19bf4289fae3e1

The --disable-werror option should have been removed at the same time.

How is the compilation breaking with Fedora 28? Can you paste the error?

This comment has been minimized.

Copy link

the-dreamer replied Sep 10, 2018

yes i see. flag is not the reason. begin of august i compiled alpha2 no issue. end of august (beta1v2) i had this issue: elfutil was complaining (out of my head) "68k struct is not aligned: warn as error". i have updated to 173 and it was fixing the issue. of course the current build on my disc is not complaining anymore. next full build i will check again and will report if it is still an issue.

This comment has been minimized.

Copy link

the-dreamer replied Sep 19, 2018

here we are:
Current master (from yesterday), build with PROJECT=Generic ARCH=x86_64 make image

In file included from /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.170/backends/m68k_corenote.c:72:
/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.170/backends/linux-core-note.c:116:1: error: alignment 2 of 'struct m68k_prstatus' is less than 4 [-Werror=packed-not-aligned]
;
^
/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.170/backends/linux-core-note.c:110:5: error: '({anonymous})' offset 70 in 'struct m68k_prstatus' isn't aligned to 4 [-Werror=packed-not-aligned]
;
^
cc1: all warnings being treated as errors
make[3]: *** [Makefile:751: m68k_corenote.o] Error 1
make[3]: *** Waiting for unfinished jobs....
rm m68k_retval.o sparc_initreg.o ppc_cfi.o x86_64_symbol.o ppc_auxv.o alpha_symbol.o arm_auxv.o m68k_symbol.o i386_unwind.o sparc_symbol.o x86_64_syscall.o i386_auxv.o ppc_initreg.o i386_retval.o sparc_corenote.o s390_unwind.o sparc_cfi.o ppc64_corenote.o ppc_regs.o ppc64_unwind.o ppc_init.o s390_init.o tilegx_symbol.o ia64_symbol.o i386_corenote.o s390_cfi.o i386_init.o ppc_corenote.o alpha_init.o m68k_init.o x32_corenote.o s390_initreg.o arm_attrs.o ppc64_resolve_sym.o x86_64_initreg.o ia64_init.o ppc_syscall.o arm_initreg.o ppc64_retval.o x86_64_retval.o arm_cfi.o aarch64_initreg.o i386_syscall.o arm_retval.o x86_64_corenote.o arm_symbol.o ppc64_init.o aarch64_symbol.o alpha_corenote.o x86_64_cfi.o sh_symbol.o x86_64_init.o i386_regs.o s390_retval.o ppc_retval.o sparc_attrs.o bpf_regs.o ia64_regs.o arm_corenote.o aarch64_cfi.o aarch64_unwind.o sparc_init.o i386_initreg.o x86_64_unwind.o alpha_retval.o aarch64_regs.o aarch64_retval.o s390_corenote.o ia64_retval.o sparc_auxv.o sparc64_corenote.o tilegx_init.o s390_symbol.o sparc_retval.o sh_regs.o x86_64_regs.o sh_retval.o sh_corenote.o i386_cfi.o alpha_regs.o ppc64_symbol.o aarch64_init.o arm_regs.o sparc_regs.o i386_symbol.o aarch64_corenote.o m68k_regs.o alpha_auxv.o ppc_symbol.o s390x_corenote.o bpf_init.o arm_init.o s390_regs.o tilegx_retval.o ppc_attrs.o tilegx_regs.o tilegx_corenote.o sh_init.o
make[2]: *** [Makefile:482: all-recursive] Error 1
make[1]: *** [Makefile:398: all] Error 2
make[1]: Leaving directory '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.170/.x86_64-redhat-linux'
make: *** [Makefile:12: image] Fehler 2

version 173 is building:

h '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/include/elfutils'
( cd '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/lib' && ranlib libelf.a )
make[2]: Leaving directory '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.173/.x86_64-redhat-linux/libelf'
/bin/sh /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.173/config/install-sh -d /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/lib
/usr/bin/install -c libelf.so /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/lib/libelf-0.173.so
ln -fs libelf-0.173.so /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/lib/libelf.so.1
ln -fs libelf.so.1 /home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/toolchain/lib/libelf.so
make[1]: Leaving directory '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/elfutils-0.173/.x86_64-redhat-linux/libelf'
BUILD linux (target)
TOOLCHAIN make (auto-detect)
make[1]: Entering directory '/home/vncuser/libreelec/libreelec.tv/build.LibreELEC-Generic.x86_64-9.0-devel/linux-4.18.3'
HOSTCC scripts/kconfig/conf.o
YACC scripts/kconfig/zconf.tab.c
LEX scripts/kconfig/zconf.lex.c
HOSTCC scripts/kconfig/zconf.tab.o

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

MilhouseVH commented on 9adf320 Sep 19, 2018

Probably this commit: https://sourceware.org/git/?p=elfutils.git;a=commitdiff;h=17d7194d291bf91d130b78e06cbe27b290e0376d - just out of interest, maybe you can try the commit with 0.170?

Do you want to PR the bump to 0.173? Otherwise I can do it later.

This comment has been minimized.

Copy link
Contributor

MilhouseVH replied Sep 20, 2018

See #2982. Thanks for reporting.

This comment has been minimized.

Copy link

the-dreamer replied Sep 20, 2018

thank you for your effort and time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.