kodi: enable games and disable rewind by default #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to get more visibility for retroplayer so let's enable games by default. The only reason kodi doesn't do this is because it doesn't have the sense of a binary add-on repo. LibreELEC is special in that we have had this ability forever. We also want to disable rewind by default because it makes low powered devices suffer in performance. It also isn't exposed in a manner that makes it easy to use yet.
chewitt
approved these changes
Jul 15, 2018
|
I've approved this, but it would be nice to have actual working game addons - they've been broken for months. Maybe this can be automated, as it causes a lot of grief for testers. I suppose this applies to all addons, really, and not just games - we really are doing a poor job with the LE9 addon repo. |
MilhouseVH
approved these changes
Jul 15, 2018
|
@MilhouseVH agreed. We can do better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to get more visibility for retroplayer so let's enable games by default.
The only reason kodi doesn't do this is because it doesn't have the sense of a
binary add-on repo. LibreELEC is special in that we have had this ability forever.
We also want to disable rewind by default because it makes low powered devices
suffer in performance. It also isn't exposed in a manner that makes it easy to use yet.