Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libssh: update to libssh-0.8.1 #2889

Merged
merged 1 commit into from Aug 15, 2018
Merged

libssh: update to libssh-0.8.1 #2889

merged 1 commit into from Aug 15, 2018

Conversation

vpeter4
Copy link
Contributor

@vpeter4 vpeter4 commented Aug 15, 2018

make vfs.sftp kodi binary addon working
with previous version kodi crashed on start
tested with Generic build on VMware Workstation Pro

@MilhouseVH
Copy link
Contributor

Presumably this is not dependent on #2887?

@vpeter4
Copy link
Contributor Author

vpeter4 commented Aug 15, 2018

Well, I bumped this package after #2887 applied. But I think it doesn't matter because vfs.sftp addon is broken for some time now.

PKG_VERSION="0.7.5"
PKG_SHA256="6f7d5b9f3089164eec7408d35b99194b17352cce436a4a95485b511bce2aab4b"
PKG_VERSION="0.8.1"
PKG_SHA256="d17f1267b4a5e46c0fbe66d39a3e702b8cefe788928f2eb6e339a18bb00b1924"
PKG_ARCH="any"
PKG_LICENSE="OpenSource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls change it to PKG_LICENSE="BSD"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean LGPL as mentioned at https://www.libssh.org/features/ ?

Copy link
Member

@CvH CvH Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn libssh2 1.8 is BSD, libssh 0.8 LGPL ... ;D oki so PKG_LICENSE="LGPL"

and make vfs.sftp kodi binary addon working
@CvH CvH merged commit ab31e8c into LibreELEC:master Aug 15, 2018
@vpeter4 vpeter4 deleted the libssh9 branch August 16, 2018 07:34
@vpeter4
Copy link
Contributor Author

vpeter4 commented Sep 1, 2018

If libssh package is build after krb5 then there is undefined symbol GSS_C_NT_HOSTBASED_SERVICE in vfs.sftp addon. One option is to disable gssapi in libssh package with -DWITH_GSSAPI=OFF. The other options is in krb5. Or build krb5 static. No idea what is better but worth to think on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants