Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: add kodi-remote script #3019

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

CvH
Copy link
Member

@CvH CvH commented Oct 5, 2018

This script could easily extended, not sure if something important/useful is missing.
It works ootb with default Kodi settings (ssh enabled ofc).
Its partly an alternative to #3017

remote3

@DaVukovic
Copy link
Contributor

That looks pretty good to me.

👍 for merging from my side

@MilhouseVH
Copy link
Contributor

This is working fine.

Although from a style POV it would be better to pass the key (action) as an argument to com() rather than use a "global" variable, ie:

com() {
  kodi-send --action="$1" > /dev/null 2>&1
  echo -ne "\r$1\e[K";
}

while true; do
  read -r -sn1 k
  case "$k" in
    A) com "Up";;
    B) com "Down";;
...

etc.

@CvH
Copy link
Member Author

CvH commented Oct 18, 2018

@MilhouseVH updated

Copy link
Contributor

@MilhouseVH MilhouseVH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this actually works really well!

@MilhouseVH MilhouseVH merged commit bde9f81 into LibreELEC:master Oct 18, 2018
@CvH CvH deleted the 9.0/kodi-remote branch October 18, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants