config: Buildsystem cleanup #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewitt
approved these changes
Oct 24, 2018
Kwiboo
previously requested changes
Oct 24, 2018
MilhouseVH
reviewed
Oct 24, 2018
MilhouseVH
reviewed
Oct 24, 2018
MilhouseVH
reviewed
Oct 24, 2018
|
This all looks fine, apart from the comments on the "config/options: general cleanup" commit. We should decide what the team or project standard is before changing code to suit a personal standard or taste. I feel some of the changes in the mentioned commit are not following the existing de-facto project standard, which is something we should clear up before proceeding. |
antonlacon
force-pushed
the
buildsystem-to-merge
branch
from
8449f02
to
e48822f
Compare
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
antonlacon
force-pushed
the
buildsystem-to-merge
branch
4 times, most recently
from
cfae77f
to
8272c88
Compare
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
brackets around variable names shell builtin for inserting values into empty variables line indent variable quotes Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
The information within config/version contains information that is about LibreELEC the distribution, so place it there. Config/version should contain version information about the LibreELEC the buildsystem. Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
antonlacon
force-pushed
the
buildsystem-to-merge
branch
from
8272c88
to
2f7d146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some more elements of the buildsystem.
show_config: Only show information about Kodi if it is being built.
source: use https for sourceforge downloads.
options: general cleanup, making use of functions' die()
functions: check_path is only called in options, right before check_config, so just roll it into check_config (which is also only called in options)
version: this should be part of the distro information; make it such.